-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies and update CI #320
Conversation
Bumps [filesize](https://github.com/avoidwork/filesize.js) from 9.0.11 to 10.1.6. - [Changelog](https://github.com/avoidwork/filesize.js/blob/master/CHANGELOG.md) - [Commits](avoidwork/filesize.js@9.0.11...10.1.6) --- updated-dependencies: - dependency-name: filesize dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@actions/artifact](https://github.com/actions/toolkit/tree/HEAD/packages/artifact) from 2.1.11 to 2.2.0. - [Changelog](https://github.com/actions/toolkit/blob/main/packages/artifact/RELEASES.md) - [Commits](https://github.com/actions/toolkit/commits/HEAD/packages/artifact) --- updated-dependencies: - dependency-name: "@actions/artifact" dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
…s/artifact-2.2.0 build(deps): bump @actions/artifact from 2.1.11 to 2.2.0
…ze-10.1.6 build(deps): bump filesize from 9.0.11 to 10.1.6
Sorry but this is unreviewable. Over 5k changed files. |
Its because i deleted the node modules folder |
Why would you do that? |
It should exist in the user side, not in the repo, also this makes it hard to update them |
But the Action will fail to run if it does not have dependencies and AFAIK GitHub Actions will not fetch them automatically. |
Well I can do it aswell (its not that hard, u have to setup node and install deps) |
Please restore node_modules directory and its contents. It's not gonna work well like you describe and I don't think users would want us to setup node and install dependencies every time the Action is run. |
What do you mean? I mean that the action will setup and install dependencies itself. The user already needs to install them userside |
That's not how GitHub Actions work. GHA clones the action repository and runs the specified main script. It will not install any dependencies. Also, it is not the job of this action to setup node and install dependencies. |
Okay then |
No description provided.